Add test for skewed join optimization when AQE is enabled #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
skewed-join-test
branch
from
6b866aa
to
79cdc87
Compare
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
andygrove
changed the title
revans2
reviewed
Aug 14, 2020
tests/src/test/scala/com/nvidia/spark/rapids/AdaptiveQueryExecSuite.scala
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/AdaptiveQueryExecSuite.scala
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/AdaptiveQueryExecSuite.scala
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
@revans2 Thanks for the review. I've added the comments as suggested. |
|
build |
|
The test failed against Spark 3.1: The test works for me locally against Spark 3.1 (probably a different version). I will look into this. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
|
build |
|
Although the tests passed this time, they are not passing consistently, so please don't merge. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
skewed-join-test
branch
from
5105e42
to
2ce1d45
Compare
|
build |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
andygrove
changed the title
|
@revans2 @jlowe This is ready for review / re-review. The only change since the last approval is increasing the size of the skew partition in the test to fix the intermittent failures caused by compression sometimes creating a partition that fell below the threshold that would trigger the optimization. |
revans2
approved these changes
Aug 21, 2020
jlowe
approved these changes
Aug 21, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Implement skewed join test for AQE Signed-off-by: Andy Grove <andygrove@nvidia.com> * fix merge conflict + use named parameters Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add comments to address PR feedback Signed-off-by: Andy Grove <andygrove@nvidia.com> * split test into three tests Signed-off-by: Andy Grove <andygrove@nvidia.com> * rig the skew amount to compensate for compression when running on GPU Signed-off-by: Andy Grove <andygrove@nvidia.com> * add comment re adjusted skew amount Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Implement skewed join test for AQE Signed-off-by: Andy Grove <andygrove@nvidia.com> * fix merge conflict + use named parameters Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add comments to address PR feedback Signed-off-by: Andy Grove <andygrove@nvidia.com> * split test into three tests Signed-off-by: Andy Grove <andygrove@nvidia.com> * rig the skew amount to compensate for compression when running on GPU Signed-off-by: Andy Grove <andygrove@nvidia.com> * add comment re adjusted skew amount Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports a skewed join test over from Spark and closes #515.
The original test had a skew size on the right-hand side that was only just over the threshold that would cause the skew join optimization to become effective. This worked intermittently on GPU because compression would sometimes cause the resulting partition to fall below the threshold, depending on the ordering of data within the columns being written to the shuffle files. The test is modified to use a larger skew partition to avoid this.