Qualification tool: Parsing Execs to get the ExecInfo #2 #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
May 5, 2022
tools/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
GlobalLimit and LocalLimit are in LogicalPlan and not in PhysicalPlan of nds_q86_test eventlog. So I couldn't use that eventlog for testing those execs. |
|
build |
1 similar comment
|
build |
tgravescs
reviewed
May 5, 2022
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
tgravescs
approved these changes
May 5, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5361. It is a follow on PR of #5420.
Execs supported in this PR:
Have added eventlog for testing GlobalLimit and LocalLimitExec. These execs are not present in final physical plan if
collectis called. So the eventlog is generated usingshow(df.limit(10).show). For rest of the execs, we create eventlogs on thr fly in the test itself.