-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support map_filter
operator
#5436
Conversation
Signed-off-by: Chong Gao <res_life@163.com>
Depending on JNI PR rapidsai/cudf#10812 to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
||
// set parameter 'valueContainsNull' to the argument's `valueContainsNull` | ||
override def dataType: DataType = MapType(keyType, valueType, valueContainsNull) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
override def dataType: DataType = MapType(keyType, valueType, valueContainsNull) | |
override def dataType: DataType = argument.dataType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the one nit by @firestarman looks really good.
build |
Closes #5273
Support
map_filter
operator.map_filter
is used to filter entries in a map.The usage of
map_filter
is:e.g.:
This implementation is:
map_filter
to get a plain boolean columnlist-of-boolean
column according to the offsets column of inputted map columnapply_boolean_mask
method to filter, Refer to Segmentedapply_boolean_mask
forLIST
columns rapidsai/cudf#10773Signed-off-by: Chong Gao res_life@163.com