Qualification tool: Add support for join, pandas, aggregate execs #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
|
build |
tgravescs
reviewed
May 12, 2022
tools/src/main/scala/com/nvidia/spark/rapids/tool/planparser/HashAggregateExecParser.scala
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/planparser/ShuffledHashJoinExecParser.scala
Show resolved
Hide resolved
tools/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
tools/src/test/scala/com/nvidia/spark/rapids/tool/planparser/SqlPlanParserSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Running 1 query related to pandas generated eventlog(compressed) which was about 21K. I have included 5 different queries to generate different execs which we support(so it's about 132K). I couldn't figure out a way to easily generate the eventlog(to include pandas and other pyspark related API's in the test itself. |
|
build |
tgravescs
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5362.
This PR adds support for these execs:
HashAggregateExec
ObjectHashAggregateExec
SortAggregateExec
BroadcastHashJoinExec
BroadcastNestedLoopJoinExec
ShuffledHashJoinExec
SortMergeJoinExec
WindowExec
AggregateInPandasExec
ArrowEvalPythonExec
FlatMapGroupsInPandasExec
MapInPandasExec
WindowInPandasExec
Using static eventlog for testing pandas related execs as creating eventlog on the fly isn't easy. Have generated one eventlog which includes all the pandas related execs. Rest of the execs create eventlog while running the tests.