Fix regression in AnsiCastOpSuite with Spark 3.3.0 #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
reviewed
May 13, 2022
tgravescs
approved these changes
May 13, 2022
|
build |
1 similar comment
|
build |
|
Merged to unblock 330 build, and 340 development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5457
AnsiCastOpSuite has assertions that look for an ANSI cast in a query plan. Prior to Spark 3.3.0 we could use toString to see if the name of the cast was "cast" or "ansi_cast" but now the name is always "cast" so we need to use reflection to access the protected field "ansiEnabled".