Fix whitespace character class tests #5522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s expansion to rewrite Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
build |
andygrove
reviewed
May 18, 2022
|
I think there are two separate changes in this PR, one for tests (related to whitespace) and one for a bug ( not handling when a predefined character class is used immediately after a string anchor ). The changes ought to be in separate PRs. |
revans2
previously approved these changes
May 18, 2022
andygrove
previously approved these changes
May 18, 2022
…into whitespace-tests Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
Will split into two separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\sand\Swere not testing the intended code path. This PR fixes it by using double backslashesa\Z\V) which caused the transpilation to be incorrect. To fix this, I moved the rewriting of character classes\s, \S, \v, \V, \h, \Hto therewrite()stage and factored out the logic handle negated character classesSigned-off-by: Anthony Chang antchang@nvidia.com