Enable forcePositionEvolution for 321cdh #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
jlowe
approved these changes
May 18, 2022
revans2
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the value of
forcePositionEvolutionfrom the configuration instead of the hardcodefalsefor 321cdh shim, since 321cdh also supportsforcePositionEvolutionand GPU should follow its behavior.The test failed because when
forcePositionEvolutionis set totrue, GPU still returnsfalse, then CPU and GPU run into different pathes in methodrequestedColumnIds, producing different output.fixes #5511
Signed-off-by: Firestarman firestarmanllc@gmail.com