Fix build warnings for ColumnViewAccess #555
Conversation
Signed-off-by: Kuhu Shukla <kuhus@nvidia.com>
kuhushukla
added
bug
| @@ -198,10 +199,10 @@ static final DataType getSparkType(DType type) { | |||
| } | |||
| } | |||
|
|
|||
| protected static final DataType getSparkTypeFrom(ColumnViewAccess access) { | |||
| protected static final DataType getSparkTypeFrom(ColumnViewAccess<BaseDeviceMemoryBuffer> access) { | |||
There was a problem hiding this comment.
Will we never need to call this method from host column vectors?
There was a problem hiding this comment.
Adding this call to host side is not on the cards right now. Also, since this call is coming from column vector, which will always have device memory buffers at least for now, I made this change under this assumption.
There was a problem hiding this comment.
Maybe I can just look at ignoring this error. To be safe.
There was a problem hiding this comment.
Yeah we could add a warning suppression to allow this to be called from the host side in the future.
There was a problem hiding this comment.
Sounds good. You got it! Thanks Jason. Updating soon.
There was a problem hiding this comment.
You could also make the method generic and not worry about it.
protected static final <T> DataType getSparkTypeFrom(ColumnViewAccess<T> access) { ...
There was a problem hiding this comment.
Sorry I was out sick yesterday. Sounds good Bobby. Will update in a couple minutes here.
|
build |
* Fix build warnings for ColumnViewAccess Signed-off-by: Kuhu Shukla <kuhus@nvidia.com> * Address review comments Co-authored-by: Kuhu Shukla <kuhus@nvidia.com>
* Fix build warnings for ColumnViewAccess Signed-off-by: Kuhu Shukla <kuhus@nvidia.com> * Address review comments Co-authored-by: Kuhu Shukla <kuhus@nvidia.com>
…IDIA#555) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Signed-off-by: Kuhu Shukla kuhus@nvidia.com
This fixes #553 by adding the type we expect ColumnVectors to have. Appreciate any comments if there is a better way to do this.