Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix target file for update from extra-resources in dist module #5558

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix target file for update from extra-resources in dist module #5558

merged 1 commit into from
May 20, 2022

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented May 20, 2022 •
edited
Loading

This PR fixes the target artifact file name for the update with extra-resources.

Closes #5557.

Signed-off-by: Gera Shegalov gera@apache.org

@gerashegalov
Fix target file for update from extra-resources
1059f1b 
Closes NVIDIA#5557

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author 

$ ./build/buildall --clean --profile=311,321 --module=integration_tests
$ ls -al dist/target/rapids-4-spark_* | wc -l
1

@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov changed the title Fix target file for update from extra-resources Fix target file for update from extra-resources in dist module May 20, 2022
@gerashegalov gerashegalov self-assigned this May 20, 2022
@gerashegalov gerashegalov added bug Something isn't working build Related to CI / CD or cleanly building P0 Must have for release labels May 20, 2022
@gerashegalov gerashegalov added this to the May 2 - May 20 milestone May 20, 2022
@gerashegalov gerashegalov merged commit 7471df5 into NVIDIA:branch-22.06 May 20, 2022
@gerashegalov gerashegalov deleted the gerashegalov/issue5557 branch May 20, 2022 16:23
NvTimLiu added a commit to NvTimLiu/spark-rapids that referenced this pull request May 21, 2022
@NvTimLiu
nightly CI to install and deploy cuda11 classifier dist jar [skip ci]
30f5f11 
As we do not gererate dist jar without cuda11 classifier after PR NVIDIA#5558

Change nightly CI job accordingly

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu mentioned this pull request May 22, 2022
Merged
NvTimLiu added a commit to NvTimLiu/spark-rapids that referenced this pull request May 22, 2022
@NvTimLiu
nightly CI to install and deploy cuda11 classifier dist jar [skip ci]
4c22fdd 
As we do not generate dist extra-resource jar without cuda11 classifier after PR NVIDIA#5558

Change nightly CI job accordingly

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu mentioned this pull request May 22, 2022
Closed
pxLi pushed a commit that referenced this pull request May 23, 2022
@NvTimLiu
nightly CI to install and deploy cuda11 classifier dist jar [skip ci] (…
11dfca6 
…#5581)

As we do not generate dist extra-resource jar without cuda11 classifier after PR #5558

Change nightly CI job accordingly

Signed-off-by: Tim Liu <timl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working build Related to CI / CD or cleanly building P0 Must have for release
Projects
None yet
Milestone
May 2 - May 20
Development

Successfully merging this pull request may close these issues.

[BUG] dist jar does not contain reduced pom, creates an unnecessary jar
2 participants
@gerashegalov @jlowe