getCatalog can be called from the driver, and can return null #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
npe_shuffle_removal
branch
from
a06600e
to
b8ca45f
Compare
jlowe
added
bug
jlowe
approved these changes
Aug 14, 2020
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…#562) Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…#562) Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* Added string to decimal conversions. Signed-off-by: Mike Wilson <knobby@burntsheep.com> Co-authored-by: Nghia Truong <nghiatruong.vn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556
When unregistering shuffles we blindly call
unregisterGpuShufflefrom the driver or executor. This depends on a lazy val that needs aGpuShuffleEnvinitialized (we need RMM for our storage, and the driver doesn't have RMM/CUDA so we don't have storage and therefore theGpuShuffleEnvis never initialized). This makes the driver not fail with an NPE in this case as the shuffle manager already was checking for a null catalog.