Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install locales and generate en_US.UTF-8 #5627

Merged
merged 2 commits into from
May 27, 2022
Merged

Install locales and generate en_US.UTF-8 #5627

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96eb861
Set language to en_US.UTF-8
GaryShen2008 May 25, 2022
6c1ce9b
Install locales and generate UTF-8
GaryShen2008 May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jenkins/Dockerfile-blossom.ubuntu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,8 @@ RUN mkdir -p /tmp/ucx && \

# export JAVA_HOME for mvn option 'source-javadoc'
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64

# install locale and use UTF-8
RUN apt-get install -y locales
RUN locale-gen en_US.UTF-8
ENV LANG en_US.UTF-8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the unit test in the Docker container, but what about someone who runs the test outside of this container (i.e.: everybody other than CI) who doesn't happen to have LANG=en_US.UTF-8 setup in their environment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum, we should document this requirement for correct behavior for regexp handling of Unicode text. We could also consider falling back to CPU if LANG != en_US.UTF-8.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to make sure this issue isn't considered "fixed" because we finally got the tests to pass. Filed #5629 to track it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated the PR as my comment. It doesn't fix the issue, but prepare the condition to fix it in test scripts.