Fix edge case where one side of regexp choice ends in duplicate string anchors #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <antchang@nvidia.com>
…x-5654-double-anchor-around-choice Signed-off-by: Anthony Chang <antchang@nvidia.com>
anthony-chang
changed the title
|
build |
andygrove
reviewed
May 27, 2022
| @@ -1169,13 +1169,18 @@ class CudfRegexTranspiler(mode: RegexMode) { | |||
| def endsWithLineAnchor(e: RegexAST): Boolean = { | |||
| e match { | |||
| case RegexSequence(parts) if parts.nonEmpty => | |||
| endsWithLineAnchor(parts.last) | |||
| val j = parts.lastIndexWhere { | |||
| case RegexEmpty() => false | |||
There was a problem hiding this comment.
This looks fine for this specific instance but do you think it is worth introducing a new step where we rewrite the AST tree and discard any RegexEmpty instances?
There was a problem hiding this comment.
Where would we have this step though? rewrite will be where all the RegexEmptys are introduced, and discarding them after rewrite won't be useful.
There was a problem hiding this comment.
I see. Ok, let's see if there are other cases that come up where we need to add explicit handling of RegexEmpty and if so then we may want to at least introduce some utility methods.
andygrove
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5654
cuDF does not support choice where either side ends with a string anchor. However, when we had a sequence ending in something like
$$, it would get compiled asRegexChar('$'), RegexEmpty()so checking only the last part of the sequence is not enough.Signed-off-by: Anthony Chang antchang@nvidia.com