Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualification tool Enable UI by default #5677

Merged
merged 1 commit into from
May 27, 2022
Merged

Qualification tool Enable UI by default #5677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationArgs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,12 @@ Usage: java -cp rapids-4-spark-tools_2.12-<version>.jar:$SPARK_HOME/jars/*
val userName: ScallopOption[String] =
opt[String](required = false,
descr = "Applications which a particular user has submitted." )
val uiEnabled: ScallopOption[Boolean] =
opt[Boolean](required = false,
descr = "Whether to render the report into HTML pages. Default is false",
default = Some(QualificationArgs.DEFAULT_UI_ENABLED))
val htmlReport : ScallopOption[Boolean] =
toggle("html-report",
default = Some(true),
prefix = "no-",
descrYes = "Generates an HTML Report. Enabled by default.",
descrNo = "Disables generating the HTML report.")

validate(order) {
case o if (QualificationArgs.isOrderAsc(o) || QualificationArgs.isOrderDesc(o)) => Right(Unit)
Expand Down Expand Up @@ -158,8 +160,6 @@ Usage: java -cp rapids-4-spark-tools_2.12-<version>.jar:$SPARK_HOME/jars/*
}

object QualificationArgs {
val DEFAULT_UI_ENABLED = false

def isOrderAsc(order: String): Boolean = {
order.toLowerCase.startsWith("asc")
}
Expand Down
2 changes: 1 addition & 1 deletion tools/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationMain.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ object QualificationMain extends Logging {
val timeout = appArgs.timeout.toOption
val reportReadSchema = appArgs.reportReadSchema.getOrElse(false)
val order = appArgs.order.getOrElse("desc")
val uiEnabled = appArgs.uiEnabled.getOrElse(false)
val uiEnabled = appArgs.htmlReport.getOrElse(false)

val hadoopConf = new Configuration()

Expand Down