Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the error message to be checked for 330 #5705

Closed
wants to merge 2 commits into from

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Jun 1, 2022

PR #5675 updated the error message before but according to the old Spark 3.3.0 snapshot jars (May 3).

While spark 3.3.0 release is still being produced, and the error message has been changed by apache/spark#36428 according to its development branch branch-3.3.

Signed-off-by: Firestarman firestarmanllc@gmail.com

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

@tgravescs
Copy link
Collaborator

If this is 3.3.0 why isn't it targetted for 22.06? Also please be more specific in description about what error message has changed and preferrably point to the spark issue that has changed the error message.

@firestarman
Copy link
Collaborator Author

firestarman commented Jun 2, 2022

If this is 3.3.0 why isn't it targetted for 22.06? Also please be more specific in description about what error message has changed and preferrably point to the spark issue that has changed the error message.

I found the PR and updated the description. This piece of code is different from 06, who has no branch for Spark 340. I will file another PR for it.

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

firestarman commented Jun 2, 2022

Here it is #5718 for 22.06

@firestarman
Copy link
Collaborator Author

build

@firestarman
Copy link
Collaborator Author

Closing this, since #5718 will be picked into 08 by automation, and it will conflict. We can get this done by fixing the conflict.

@firestarman firestarman closed this Jun 2, 2022
@firestarman firestarman deleted the div_err_message branch June 8, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants