Fix Databricks shim layer for GpuFileSourceScanExec and GpuBroadcastExchangeExec #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@apache.org>
Signed-off-by: Thomas Graves <tgraves@apache.org>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
…nto dbFileSourceFix
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@apache.org>
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
jlowe
approved these changes
Aug 17, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…xchangeExec (NVIDIA#571) * Make GpuFileSourceScanExec work with Databricks Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Add in GpuFileScanRDD Signed-off-by: Thomas Graves <tgraves@nvidia.com> * cleanup Signed-off-by: Thomas Graves <tgraves@apache.org> * Rework to get PartitionedFiles only Signed-off-by: Thomas Graves <tgraves@apache.org> * remove commented out code Signed-off-by: Thomas Graves <tgraves@apache.org> * Fix spacing in pom Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Add gpu broadcast get function and fix names Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove unused imports Signed-off-by: Thomas Graves <tgraves@apache.org> Co-authored-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…xchangeExec (NVIDIA#571) * Make GpuFileSourceScanExec work with Databricks Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Add in GpuFileScanRDD Signed-off-by: Thomas Graves <tgraves@nvidia.com> * cleanup Signed-off-by: Thomas Graves <tgraves@apache.org> * Rework to get PartitionedFiles only Signed-off-by: Thomas Graves <tgraves@apache.org> * remove commented out code Signed-off-by: Thomas Graves <tgraves@apache.org> * Fix spacing in pom Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Add gpu broadcast get function and fix names Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove unused imports Signed-off-by: Thomas Graves <tgraves@apache.org> Co-authored-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#571) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databricks has a bunch of changes in the FileSourceScanExec and DataSourceScanExec so we have to do extra stuff there. In addition they use a different version of FileStatus. So we had to shim some of the functions around using the FileStatus. I had to pull in FileScanRDD into our shim layer. I verified the metrics work on databricks for the GpuFileSourceScanExec.
Also there were changes from GpuBroadcastExchangeExec missing from databricks shim.