-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the ORC encryption tests [databricks] #5737
Remove the ORC encryption tests [databricks] #5737
Conversation
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
… 3.1.x Signed-off-by: Raza Jafri <rjafri@nvidia.com>
please put a description of changes made and why |
build |
frame => | ||
// ORC encryption is only allowed in 3.2+ | ||
val isValidTestForSparkVersion = SparkShimImpl.getSparkShimVersion match { | ||
case SparkShimVersion(major, minor, _) => major == 3 && minor != 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need these checks if this is in a 320+ directory right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we don't. I am being defensive here in case someone moves things around. If this is an issue, I can remove them
Build failure is due to #5744 |
build |
withCpuSparkSession(session => { | ||
val conf = session.sessionState.newHadoopConf() | ||
val provider = HadoopShimsFactory.get.getHadoopKeyProvider(conf, new Random) | ||
assume(!provider.getKeyNames.isEmpty, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't testing anything the way its written, we need a different way to test
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need another issue filed to add a working test back
|
build |
This PR removes the ORC encryption test
There will be a follow-on PR for adding tests
fixes #5733
Signed-off-by: Raza Jafri rjafri@nvidia.com