Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle regexp_replace inconsistency with empty strings and zero-repetition patterns [databricks] #5740

Merged
merged 18 commits into from
Jun 8, 2022
Merged

Handle regexp_replace inconsistency with empty strings and zero-repetition patterns [databricks] #5740

merged 18 commits into from
Jun 8, 2022

Commits on Jun 3, 2022

  1. shim layer for regexp

    @andygrove
    andygrove committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    e3b81d6 View commit details
    Browse the repository at this point in the history

  2. rough out handing of empty string bug

    @andygrove
    andygrove committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    cd7dbf3 View commit details
    Browse the repository at this point in the history

  3. Add licences to shim files, check for empty repetition 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    40b21c0 View commit details
    Browse the repository at this point in the history

  4. Update integration test 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    951d455 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Recursively check for only empty repetition in regex 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    65b9f8e View commit details
    Browse the repository at this point in the history

  2. Fix license date 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    6256bd8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-22.08' of github.com:nvidia/spark-rapids into re… 

    …gexp-shim-5456
    @anthony-chang
    anthony-chang committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    6a8db81 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Add 321cdh shim 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3345728 View commit details
    Browse the repository at this point in the history

  2. Move shim file 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    2dbca58 View commit details
    Browse the repository at this point in the history

  3. Remove a shim file 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    be93d92 View commit details
    Browse the repository at this point in the history

  4. Add comma 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    6e0f2ba View commit details
    Browse the repository at this point in the history

  5. Handle case where AST root is a RegexSequence 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    bce08b9 View commit details
    Browse the repository at this point in the history

  6. Add shim to 321db 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    ce644c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Handle case where pattern contains more than 1 empty repetition 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    364764e View commit details
    Browse the repository at this point in the history

  2. Update comment 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e7a6e2c View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Andy Grove <andygrove73@gmail.com>
    @anthony-chang @andygrove
    anthony-chang and andygrove authored Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a4584d5 View commit details
    Browse the repository at this point in the history

  4. Refactor isEmptyRepetition logic to RegExpUtils 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    916ab64 View commit details
    Browse the repository at this point in the history

  5. Fix scalastyle 

    Signed-off-by: Anthony Chang <antchang@nvidia.com>
    @anthony-chang
    anthony-chang committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    194a42f View commit details
    Browse the repository at this point in the history