Update the error string for test_cast_neg_to_decimal_err on 330[databricks] #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
GaryShen2008
reviewed
Jun 8, 2022
| @@ -301,7 +302,9 @@ def test_mod_pmod_by_zero(data_gen, overflow_exp): | |||
| def test_cast_neg_to_decimal_err(): | |||
| # -12 cannot be represented as decimal(7,7) | |||
| data_gen = _decimal_gen_7_7 | |||
| exception_content = "Decimal(compact,-120000000,20,0}) cannot be represented as Decimal(7, 7)" | |||
| dec_value = "Decimal(compact,-120000000,20,0})" if is_before_spark_330() \ | |||
| or is_databricks_runtime() else "Decimal(compact, -120000000, 20, 0)" | |||
There was a problem hiding this comment.
Will this check fail again if databricks has a version of spark 330?
res-life
reviewed
Jun 8, 2022
|
build |
res-life
previously approved these changes
Jun 8, 2022
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
res-life
approved these changes
Jun 8, 2022
tgravescs
added a commit
that referenced
this pull request
Jun 8, 2022
* Correct the error message for test_mod_pmod_by_zero (#5781) Signed-off-by: Firestarman <firestarmanllc@gmail.com> * Update the error string for test_cast_neg_to_decimal_err on 330[databricks] (#5784) * Update the error string for test_cast_neg_to_decimal_err on 330 Signed-off-by: Firestarman <firestarmanllc@gmail.com> * address comments Signed-off-by: Firestarman <firestarmanllc@gmail.com> * Throw an exception when attempting to read columnar encrypted Parquet files on the GPU [databricks] (#5761) * Throw useful message when parquet columnar encryption enabled * update message * fix message * handle native encrypted * move variable * cleanup * fix native check * cleanup imports * fix import order * Sign off Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Shim the parquet crypto exception check Signed-off-by: Thomas Graves <tgraves@nvidia.com> * shim 320cdh * Add test for parquet encryption Signed-off-by: Thomas Graves <tgraves@nvidia.com> * fix rounds over decimal in Spark 330+ (#5786) Passes the datatype of round-like functions directly to GPU overrides, so as to adapt different Spark versions. Signed-off-by: sperlingxx <lovedreamf@gmail.com> * Fix the overflow of container type when casting floats to decimal (#5766) Fixes #5765 Fix the potential overflow when casting float/double to decimal. The overflow occurs on the container decimal for HALF_UP round. Signed-off-by: sperlingxx <lovedreamf@gmail.com> Co-authored-by: Liangcai Li <firestarmanllc@gmail.com> Co-authored-by: Alfred Xu <lovedreamf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5769
It fixes only the failing
test_cast_neg_to_decimal_errtest.Signed-off-by: Firestarman firestarmanllc@gmail.com