Fall back to CPU for RoundCeil and RoundFloor expressions #5798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to test failures in #5769 esp test_floor* and test_ceil* tests.
While debugging above failures found another bug where a simple ceil on Decimal type was failing.
Looks like it was introduced while working on RoundCeil where the
maxPrecision
was added. Above bug is fixed when themaxPrecision
calculation is reverted.Currently we support RoundCeil/RoundFloor only when
scale=0
. We have a case where the tests fail when DecimalType(18,0) is given as input. So we are falling back to CPU whenever there is RoundCeil and RoundFloor expr in this PR.Created a follow-on issue to debug above case and enable these expressions - #5797