Add support for null characters in regular expressions #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <antchang@nvidia.com>
anthony-chang
commented
Jun 15, 2022
| if (endsWithLineAnchor(ll) || endsWithLineAnchor(rr)) { | ||
| throw new RegexUnsupportedException( | ||
| "cuDF does not support terms ending with line anchors on one side of a choice") | ||
| } | ||
|
|
||
| // cuDF does not support terms ending with word boundaries on one side | ||
| // of a choice, such as "\\b|a" | ||
| if (endsWithWordBoundary(ll) || endsWithWordBoundary(rr)) { |
There was a problem hiding this comment.
Added in this PR because the updated fuzz tests caught this case
sameerz
added
the
task
andygrove
previously approved these changes
Jun 15, 2022
|
build |
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
anthony-chang
changed the title
Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
build |
NVnavkumar
reviewed
Jun 24, 2022
Null characters still don't work in character classes. We can do this after rapidsai/cudf#11112 is merged |
Can you file a tracking issue for the plugin on this bug and note it in the code around those character classes? |
Signed-off-by: Anthony Chang <antchang@nvidia.com>
|
build |
3 tasks
NVnavkumar
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5846
Adds support for the null character
\u0000in regular expressions.cuDF requires null characters to be represented as
\0rather than the literal\u0000. But we can't simply transpile\u0000to\0since patterns such as\u00002(ie. null character followed by a 2) would transpile to\02(ie. the octal digit with codepoint=2) so we instead transpile\u0000to(?:\0)I've also left null characters disabled in character classes due to a cuDF bug rapidsai/cudf#11109
Signed-off-by: Anthony Chang antchang@nvidia.com