Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default speedup factors for qualification tool #5842

Merged

Conversation

mattahrens
Copy link
Collaborator

Signed-off-by: mattahrens matthewahrens@gmail.com

Fixes #5831

Updating exec default speedup factor to 3 and expression default speedup factor (not yet used) to 4. Also updated Sort and SortMergeJoin based on recent performance tests.

Signed-off-by: mattahrens <matthewahrens@gmail.com>
Signed-off-by: mattahrens <matthewahrens@gmail.com>
@mattahrens mattahrens changed the title Update default speedups qual 5831 Update default speedup factors for qualification tool Jun 15, 2022
@mattahrens
Copy link
Collaborator Author

build

nartal1
nartal1 previously approved these changes Jun 15, 2022
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tgravescs
tgravescs previously approved these changes Jun 15, 2022
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to update the documentation example and the integration test results. Perhaps we should file a separate issue for documentation since we will be adding expressions and other things anyway.

@amahussein
Copy link
Collaborator

This will conflict with pending #5810
If @mattahrens going to be away, I do not mind merging this PR first, then I can revisit #5810

@mattahrens
Copy link
Collaborator Author

issue filed for 22.08 doc updates for qualification tool: #5843

Signed-off-by: mattahrens <matthewahrens@gmail.com>
@mattahrens mattahrens dismissed stale reviews from tgravescs and nartal1 via b251b80 June 15, 2022 19:10
@mattahrens
Copy link
Collaborator Author

build

@mattahrens mattahrens merged commit d9d9e73 into NVIDIA:branch-22.08 Jun 15, 2022
@mattahrens mattahrens self-assigned this Jun 15, 2022
@mattahrens mattahrens added this to the Jun 6 - Jun 17 milestone Jun 15, 2022
@mattahrens mattahrens deleted the update-default-speedups-qual-5831 branch June 15, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Update default speedup factors used for qualification tool
4 participants