Add Apache Spark 3.3.1-SNAPSHOT Shims #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
Signed-off-by: Anthony Chang <antchang@nvidia.com>
tgravescs
reviewed
Jun 21, 2022
There was a problem hiding this comment.
In the future if you can add any details of things that changed or if everything the same just say 331 shim is same as 330 except version, that would help the reviewers out.
Is there a reason this was in draft? Again if you can add comment that would be great.
sql-plugin/src/main/331/scala/com/nvidia/spark/rapids/shims/ParquetSchemaClipShims.scala
Outdated
Show resolved
Hide resolved
...1/scala/org/apache/spark/sql/execution/datasources/parquet/rapids/shims/ParquetCVShims.scala
Outdated
Show resolved
Hide resolved
anthony-chang
changed the title
anthony-chang
changed the title
anthony-chang
requested review from
jlowe,
revans2,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
tgravescs
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5867
This PR adds shims for Spark version 3.3.1-SNAPSHOT, and a
330until340shims folder. The shims should be identical to 3.3.0 except version number.