Fix misleading documentation for approx_percentile and some other functions
#5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
fix-approx-percentile-incompat
branch
from
655c0d8
to
d6bf5b9
Compare
revans2
reviewed
Jun 21, 2022
andygrove
changed the title
approx_percentile as incompatapprox_percentile as incompat
andygrove
changed the title
approx_percentile as incompatapprox_percentile and some other functions
andygrove
changed the title
approx_percentile and some other functionsapprox_percentile and some other functions
sameerz
approved these changes
Jun 27, 2022
revans2
approved these changes
Jun 27, 2022
|
build |
1 similar comment
|
build |
sameerz
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated documentation stated that some expressions were disabled by default but this was not accurate now that
spark.rapids.sql.incompatibleOps.enabledis true by default.This PR changes the documentation generator to respect the default value of
spark.rapids.sql.incompatibleOps.enabledwhen determining if expressions are enabled.The
incompatmessage forApproxPercentileis also updated to remove the text about enablingspark.rapids.sql.incompatibleOps.enabled.