Avoid serializing plan in GpuCoalesceBatches, GpuHashAggregateExec, and GpuTopN #5886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd GpuTopN Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
1 similar comment
|
build |
abellina
approved these changes
Jun 22, 2022
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with the RDD closures in GpuCoalesceBatches, GpuHashAggregateExec, and GpuTopN to avoid serializing the plan object and all child nodes. References to member variables were converted into local variables to sever the dependency between the closure and exec node object.