Make the error message of changing decimal type the same as Spark's [databricks] #5915
Conversation
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
|
CI error: https://github.com/NVIDIA/spark-rapids/runs/7067135922?check_suite_focus=true#step:2:5245, |
|
build |
| fromType: DecimalType, | ||
| toType: DecimalType, | ||
| context: String = ""): ArithmeticException = { | ||
| val row_id = withResource(outOfBounds.copyToHost()) {hcv => |
There was a problem hiding this comment.
My only real nit is that there is a lot of copy and paste between the 4 implementations of this code. Is there a ways we can make this more common?
There was a problem hiding this comment.
Yes, I can extra some common expressions to be a new helper function. But I am not sure where to put the helper.
There was a problem hiding this comment.
Only GpuCeil and GpuFloor do this. I would create a trait or an object in mathExpressions.scala and name it something like FloorCeilErrorUtil or RoundingErrorUtil and add it there.
sameerz
added
the
task
|
build |
Signed-off-by: remzi <13716567376yh@gmail.com>
|
build |
|
The failure seems not related to this PR: https://github.com/NVIDIA/spark-rapids/runs/7124317772?check_suite_focus=true#step:2:34524 |
|
@revans2 Please have a look. Thank you! |
|
|
||
| object RapidsErrorUtils { | ||
| object RapidsErrorUtils extends { |
There was a problem hiding this comment.
Why is there an "extends" here that is not used?
sql-plugin/src/main/321db/scala/org/apache/spark/sql/rapids/shims/RapidsErrorUtils.scala
Outdated
Show resolved
Hide resolved
…ims/RapidsErrorUtils.scala
|
build |
1 similar comment
|
build |
|
The failure test is not related to this PR. https://github.com/NVIDIA/spark-rapids/runs/7159690760?check_suite_focus=true#step:2:34528 |
Looks like the issue for this failure is #5937 I am inclined to let this PR wait until the issue is resolved, but if others have a different option I can admin merge it. |
|
build |
1 similar comment
|
build |
pxLi
changed the title
Signed-off-by: remzi 13716567376yh@gmail.com
Related to #5196.
Rationale for this change
We want to throw the same error message as Spark.
Changes in this PR.
cannotChangeDecimalPrecisionErrorto find which value causes the error, so that we could throw the same error message as Spark.update_test_floor_ceil_overflowto check the error message more precisely.java.lang.ArithmeticExceptionbefore Spark 3.3.0 andSparkArithmeticExceptionafter 330). The content of error message is not checked because I don't find a good way to get the value ofdata_gen