Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GpuAdd and GpuSubtract to throw same type exception as Spark #5949

Merged

Conversation

HaoYang670
Copy link
Collaborator

Signed-off-by: remzi 13716567376yh@gmail.com
Related to #5196

Changes in the PR

  1. Update GpuAdd and GpuSubtract to throw same type exception as Spark
  2. Update test cases: test_add_overflow_with_ansi_enabled_day_time_interval, test_subtraction_overflow_with_ansi_enabled_day_time_interval and test_logical_with_side_effect to check the exception type.

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@HaoYang670
Copy link
Collaborator Author

build

@HaoYang670 HaoYang670 merged commit 08488a6 into NVIDIA:branch-22.08 Jul 6, 2022
@HaoYang670 HaoYang670 deleted the update_GpuAdd_and_GpuSubtract branch July 6, 2022 02:12
@sameerz sameerz added the task Work required that improves the product but is not user facing label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants