Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] add app-details to qualification tools doc [skip ci] #5972

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me

fixes #5963

Changes in spark-qualification-tool.md

  • describe the App-details view and add screen shots to the HTML.
  • fixed a broken link [Fields Interpretations](#fields-interpretations)
  • fixed some formatting issues. making field names in italic style.
  • added tree structure to the output folder.

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein amahussein self-assigned this Jul 8, 2022
@amahussein
Copy link
Collaborator Author

build

1 similar comment
@amahussein
Copy link
Collaborator Author

build

The search box will match on multiple columns including: "_App ID_", "_App Name_", "_Recommendation_",
"_User Name_", "_Unsupported Write Data Format_", "_Complex Types_", "_Nested Complex Types_", and "_Read Schema_".
The detailed table can also be exported as `Qualification Tool Dashboard – Raw Data.csv`.

Note that this table has too many columns. Therefore, the UI application dynamically optimizes the layout of the table
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "too many columns", reword to say "more columns than can fit in a normal browser window."

mattahrens
mattahrens previously approved these changes Jul 11, 2022
Copy link
Collaborator

@mattahrens mattahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but LGTM 👍

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
@amahussein amahussein added the documentation Improvements or additions to documentation label Jul 11, 2022
@amahussein
Copy link
Collaborator Author

build

@amahussein amahussein merged commit e02103f into NVIDIA:branch-22.08 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] add app-details to qualification tools doc
3 participants