Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Strings as a supported type for GpuColumnarToRow transitions #5998

Merged
merged 27 commits into from
Jul 27, 2022
Merged

Enable Strings as a supported type for GpuColumnarToRow transitions #5998

merged 27 commits into from
Jul 27, 2022

Commits on Jul 13, 2022

  1. Enable Strings as a supported type for GpuColumnarToRow transitions 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    61ec025 View commit details
    Browse the repository at this point in the history

  2. add codeGen and move all code to the Util class 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

fix the type of the dataOffsetTmp

Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    51ee98d View commit details
    Browse the repository at this point in the history

  3. add unitTests 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    42955c7 View commit details
    Browse the repository at this point in the history

  4. add null check to the string copy 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    429aa08 View commit details
    Browse the repository at this point in the history

  5. fix a bug in calculating string offsets 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3136197 View commit details
    Browse the repository at this point in the history

  6. add unit test for jcudf size estimator 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    5d49093 View commit details
    Browse the repository at this point in the history

  7. adjust the packing of the columns 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    02b27b4 View commit details
    Browse the repository at this point in the history

  8. fix bug in string code-gen and add integration tests 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8675b63 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. fix code reviews 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    7698f6b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-22.08' into rapids-5633

    @amahussein
    amahussein committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    2e30360 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. fix failures in UT GpuCoalesceBatchesSuite 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    ca4f906 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-22.08' into rapids-5633

    @amahussein
    amahussein committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    7530509 View commit details
    Browse the repository at this point in the history

  3. add code to retry allocating row if not fit 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    5b8d399 View commit details
    Browse the repository at this point in the history

  4. remove err.println message used for debugging 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    bd3da00 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. align the newly calculated row size + replace switch statement 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    1abc07f View commit details
    Browse the repository at this point in the history

  2. change step of increasing the bufferLength 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    f4db01e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-22.08' into rapids-5633

    @amahussein
    amahussein committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    0858a7d View commit details
    Browse the repository at this point in the history

  4. rename max-row_size and rearrange reaching limit 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    15c00a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Update sql-plugin/src/main/java/com/nvidia/spark/rapids/CudfUnsafeRow… 

    ….java

Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    49b884e View commit details
    Browse the repository at this point in the history

  2. Update sql-plugin/src/main/java/com/nvidia/spark/rapids/JCudfUtil.java 

    Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    5ca64f4 View commit details
    Browse the repository at this point in the history

  3. Update integration_tests/src/main/python/row_conversion_test.py 

    Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    3c3cec5 View commit details
    Browse the repository at this point in the history

  4. Update sql-plugin/src/main/java/com/nvidia/spark/rapids/CudfUnsafeRow… 

    ….java

Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    10d251c View commit details
    Browse the repository at this point in the history

  5. Update sql-plugin/src/main/java/com/nvidia/spark/rapids/JCudfUtil.java 

    Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    6505811 View commit details
    Browse the repository at this point in the history

  6. Update sql-plugin/src/main/java/com/nvidia/spark/rapids/JCudfUtil.java 

    Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    2b5266f View commit details
    Browse the repository at this point in the history

  7. Update sql-plugin/src/main/java/com/nvidia/spark/rapids/JCudfUtil.java 

    Co-authored-by: Mike Wilson <hyperbolic2346@users.noreply.github.com>
    @amahussein @hyperbolic2346
    amahussein and hyperbolic2346 authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    5e8facb View commit details
    Browse the repository at this point in the history

  8. fix pr-feedback 

    Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
    @amahussein
    amahussein committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    a608a8d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'branch-22.08' into rapids-5633

    @amahussein
    amahussein committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    fa17ae7 View commit details
    Browse the repository at this point in the history