Update spark322shim dependency to released lib #6031
Conversation
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
requested review from
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
|
build |
|
build |
| @@ -50,7 +50,7 @@ mvn_verify() { | |||
| # enable UTF-8 for regular expression tests | |||
| env -u SPARK_HOME LC_ALL="en_US.UTF-8" mvn $MVN_URM_MIRROR -Dbuildver=320 test -Drat.skip=true -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -Dpytest.TEST_TAGS='' -pl '!tools' -DwildcardSuites=com.nvidia.spark.rapids.ConditionalsSuite,com.nvidia.spark.rapids.RegularExpressionSuite,com.nvidia.spark.rapids.RegularExpressionTranspilerSuite | |||
| env -u SPARK_HOME mvn -U -B $MVN_URM_MIRROR -Dbuildver=321 clean install -Drat.skip=true -DskipTests -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -pl aggregator -am | |||
| [[ $BUILD_MAINTENANCE_VERSION_SNAPSHOTS == "true" ]] && env -u SPARK_HOME mvn -U -B $MVN_URM_MIRROR -Dbuildver=322 clean install -Drat.skip=true -DskipTests -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -pl aggregator -am | |||
| env -u SPARK_HOME mvn -U -B $MVN_URM_MIRROR -Dbuildver=322 clean install -Drat.skip=true -DskipTests -Dmaven.javadoc.skip=true -Dskip -Dmaven.scalastyle.skip=true -Dcuda.version=$CUDA_CLASSIFIER -pl aggregator -am | |||
There was a problem hiding this comment.
Maybe it's a remark for a dedicated issue but it's related.
It looks like when we add a new patch version, we always leave the first patch version such as 3.1.1, 3.2.0 as the one on which the tests are run. I think we should rather always move the tests forward to the latest patch version, i.e. 3.1.3 and 3.2.2 to add value
In addition I think the intention of the comment on L41 is that we run tests in premerge for one patch version per feature version. Thus 330 should not skipTests.
There was a problem hiding this comment.
Sounds good to me. But since this PR is for shim update, can you maybe file an issue so we could have more people to join and discuss about this? thanks
|
Going to merge this one. If any doc update require to be updated, please let me know, I will create a followup PR |
Signed-off-by: Peixin Li pxli@nyu.edu
fix #6018, move spark322shim from snapshot to released lib