Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested struct binary comparison operator support #6062

Merged
merged 7 commits into from
Aug 12, 2022

Conversation

rwlee
Copy link
Collaborator

@rwlee rwlee commented Jul 22, 2022

Partial solution to #3149 (EqualsNullSafe and Least not covered)
Plugin PR for rapidsai/cudf#11153

Supports <, <=, >, >=, ==, and != comparisons on VectorVector, ScalarVector and VectorScalar columns.

@rwlee rwlee added the task Work required that improves the product but is not user facing label Jul 22, 2022
@jlowe
Copy link
Member

jlowe commented Jul 25, 2022

@rwlee this failed the signoff check, needs at least one commit with a signoff.

@rwlee rwlee changed the base branch from branch-22.08 to branch-22.10 August 3, 2022 18:53
@mythrocks
Copy link
Collaborator

Build

Copy link
Collaborator

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rwlee: Would you be averse to changing the description text to expand VS to Vector-Scalar, etc.?

@rwlee rwlee merged commit 9cb38c7 into NVIDIA:branch-22.10 Aug 12, 2022
@rwlee rwlee deleted the rwlee/structbinops branch August 12, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants