-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when casting decimals to long #6103
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
61151c9
Fix Decimal to Long cast
razajafri 37d4225
addressed review comments
razajafri e0d7755
added comment
razajafri 96c2afa
addressed review comments
razajafri bc27e77
renamed var
razajafri 2abec0f
refactored local vals to class vals
razajafri a267a7d
capitalize constants
razajafri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,6 +177,8 @@ object GpuCast extends Arm { | |
private val TIMESTAMP_TRUNCATE_REGEX = "^([0-9]{4}-[0-9]{2}-[0-9]{2} " + | ||
"[0-9]{2}:[0-9]{2}:[0-9]{2})" + | ||
"(.[1-9]*(?:0)?[1-9]+)?(.0*[1-9]+)?(?:.0*)?$" | ||
private val bigDecimalLongMin = BigDecimal(Long.MinValue) | ||
private val bigDecimalLongMax = BigDecimal(Long.MaxValue) | ||
|
||
val INVALID_INPUT_MESSAGE: String = "Column contains at least one value that is not in the " + | ||
"required range" | ||
|
@@ -378,10 +380,8 @@ object GpuCast extends Arm { | |
// ansi cast from larger-than-long integral-like types, to long | ||
case (dt: DecimalType, LongType) if ansiMode => | ||
// This is a work around for https://github.com/rapidsai/cudf/issues/9282 | ||
val min = BigDecimal(Long.MinValue) | ||
.setScale(dt.scale, BigDecimal.RoundingMode.DOWN).bigDecimal | ||
val max = BigDecimal(Long.MaxValue) | ||
.setScale(dt.scale, BigDecimal.RoundingMode.DOWN).bigDecimal | ||
val min = bigDecimalLongMin.setScale(dt.scale, BigDecimal.RoundingMode.DOWN).bigDecimal | ||
val max = bigDecimalLongMax.setScale(dt.scale, BigDecimal.RoundingMode.DOWN).bigDecimal | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
// We are going against our convention of calling assertValuesInRange() | ||
// because the min/max values are a different decimal type i.e. Decimal 128 as opposed to | ||
// the incoming input column type. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.