Workaround for Databricks using AQE even when disabled #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@apache.org>
tgravescs
changed the title
|
build |
1 similar comment
|
build |
revans2
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Are there any tests that we can add to verify that this is working? I know that #5981 is adding in some support for delta lake tests. Perhaps we can have a follow on issue to look into extending some of that for Databricks.
|
we don't have any current tests because we haven't been able to reproduce it consistently. I will file a followup though to see if we can narrow it down more to get a test added. |
|
#6171 filed |
|
databricks build is having timeout issues |
tgravescs
changed the title
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6158
It seems that Databricks is using AQE for some Delta stats even when we disable it in Spark. We see this on Databricks 10.4 with certain queries using delta files.
To workaround this we look for ProjectExecs that have ScalaUDFs using a function that contains tahoe.Snapshot as that is what we have seen from the stack traces. We also check explicitly for AdaptiveSparkPlan. On Databricks, we don't support AQE right now so it shouldn't be used. In both cases we fallback to the CPU to run those operations.
Tested manually on queries that were failing and no longer see these failures. Checking with customer to validate as well.