Release host buffers when Avro read schema is empty #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
wbo4958
reviewed
Aug 4, 2022
| @@ -777,6 +777,7 @@ class GpuMultiFileCloudAvroPartitionReader( | |||
|
|
|||
| val bufAndSize: Array[(HostMemoryBuffer, Long)] = if (readDataSchema.isEmpty) { | |||
There was a problem hiding this comment.
if readDataSchema is empty, can we return the value earlier without reading out the avro data?
There was a problem hiding this comment.
This is a little complicated, because it still needs to read out the data, but only the block metadata part, where contains the row number information.
Tracked by #6219
wbo4958
approved these changes
Aug 4, 2022
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6220.
Host buffers are not needed when Avro read schema is empty, so need to release them.
What's more, the host buffers are not necessary for empty read schema, so this can be an improvement. Tracked by #6219
Signed-off-by: Firestarman firestarmanllc@gmail.com