Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support float/double castings for ORC reading [databricks] #6319

Merged
merged 14 commits into from
Sep 7, 2022
Merged

Support float/double castings for ORC reading [databricks] #6319

merged 14 commits into from
Sep 7, 2022

Commits on Aug 15, 2022

  1. implement casting float/double 

    * Impl: float/double -> double/float, bool, int8/16/32/64, timestamp
* There are some precision issue when casting float/double to string
* IT Test: need a function float_gen with range [a, b]

Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    c312ecb View commit details
    Browse the repository at this point in the history

  2. Check long-overflow when casting float/double to timestamp 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    a729c86 View commit details
    Browse the repository at this point in the history

  3. Add comments in temp IT tests 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    bb2d3a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Update float/double -> timestamp, and add more test cases 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ef1163d View commit details
    Browse the repository at this point in the history

  2. Update comments 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    2930ab8 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Add a config item to control casting float/double to string in ORC re… 

    …ading.

Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    e785de1 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Refined code according to review comments 

    * Fixed bug when all elements in ColumnVector are null
* Updated IT tests

Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    c6e05a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Merge branch 'branch-22.10' into issue-6291-cast-float-double

    @sinkinben
    sinkinben committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    69e9d14 View commit details
    Browse the repository at this point in the history

  2. Refined some comments, and move orc_cast_float_test to orc_cast_test 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    0cf548a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Merge branch 'branch-22.10' into issue-6291-cast-float-double

    @sinkinben
    sinkinben committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    0b2a675 View commit details
    Browse the repository at this point in the history

  2. Fixed some conflicts and update docs about ENABLE_ORC_FLOAT_TYPES_TO_… 

    …STRING

Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    e6e1aa9 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Merge branch 'branch-22.10' into issue-6291-cast-float-double

    @sinkinben
    sinkinben committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d427a4d View commit details
    Browse the repository at this point in the history

  2. Refined float/double -> timestamp, and fixed some conflicts 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    db0f0d2 View commit details
    Browse the repository at this point in the history

  3. Fixed memory SEG fault 

    Signed-off-by: sinkinben <sinkinben@outlook.com>
    @sinkinben
    sinkinben committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    46e71f9 View commit details
    Browse the repository at this point in the history