BooleanType test shouldn't xfail #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
revans2
reviewed
Sep 2, 2020
This reverts commit 64714a5.
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
@revans2 I have addressed your concern PTAL |
|
build |
revans2
reviewed
Sep 3, 2020
| @@ -61,7 +62,7 @@ def test_passing_gpuExpr_as_Expr(): | |||
| @pytest.mark.parametrize('join_type', ['Left', 'Right', 'Inner', 'LeftSemi', 'LeftAnti'], ids=idfn) | |||
| @ignore_order | |||
| def test_cache_join(data_gen, join_type): | |||
| if data_gen.data_type == BooleanType(): | |||
| if spark_version() == "3.0.0" and data_gen.data_type == BooleanType(): | |||
| pytest.xfail("https://github.com/NVIDIA/spark-rapids/issues/350") | |||
There was a problem hiding this comment.
I would point to the spark issue for all of these instead
| @@ -41,3 +41,5 @@ def get_spark_i_know_what_i_am_doing(): | |||
| """ | |||
| return _spark | |||
|
|
|||
| def spark_version(): | |||
There was a problem hiding this comment.
I like this, but there are a number of other places in the code that are doing a
with_spark_session(spark: spark.sparkContext.version ...
It would probably be good to update all of them to be consistent or do it the same way here too.
There was a problem hiding this comment.
I have reverted the change to be more like the rest to be consistent
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
revans2
previously approved these changes
Sep 3, 2020
|
OK. let me make the change. I thought making the PR bigger will be frowned upon. |
|
build |
revans2
approved these changes
Sep 3, 2020
|
build |
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* BooleanType test shouldn't xfail Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Revert "BooleanType test shouldn't xfail" This reverts commit 64714a5. * xfail only for 3.0.0 Signed-off-by: Raza Jafri <rjafri@nvidia.com> * addressed review comments Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed the version method * Revert "removed the version method" This reverts commit a9d9a04. * Revert "addressed review comments" This reverts commit 6472e92. * added version checks * missed changing it in cache_test.py Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removing unnecessary lambda Co-authored-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* BooleanType test shouldn't xfail Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Revert "BooleanType test shouldn't xfail" This reverts commit 64714a5. * xfail only for 3.0.0 Signed-off-by: Raza Jafri <rjafri@nvidia.com> * addressed review comments Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed the version method * Revert "removed the version method" This reverts commit a9d9a04. * Revert "addressed review comments" This reverts commit 6472e92. * added version checks * missed changing it in cache_test.py Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removing unnecessary lambda Co-authored-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#639) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raza Jafri rjafri@nvidia.com
Now that https://github.com/apache/spark/pull/29506/files has been merged to branch 3.0 in spark. This is no longer needed
fixes #350