-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing closing ``` for a code block [skip ci] #6563
Conversation
Fixes formatting bug from #6555 Signed-off-by: Gera Shegalov <gera@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a $
prompt character at the beginning of line 190, 202, 204, 206, 214, 233 and 255, as is done on line 242, and changing Bash
to bash
. While both render correctly in github, only the lowercase version renders properly in github pages.
Co-authored-by: Sameer Raheja <sameerz@users.noreply.github.com>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you pointed out in https://github.com/DavidAnson/markdownlint/blob/v0.26.2/doc/Rules.md#md014 , commands that have no output do not need to be preceeded by a prompt ($
). I'm ok as is or if the prompts are removed from commands without output.
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
build |
Fixes formatting bug from #6555
Signed-off-by: Gera Shegalov gera@apache.org