-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for GPU exchange re-use with AQE #674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
[WIP] Unit test for exchange re-use with AQE
Unit test for exchange re-use with AQE
Sep 8, 2020
build |
andygrove
changed the title
Unit test for exchange re-use with AQE
Unit test for GPU exchange re-use with AQE
Sep 8, 2020
build |
nartal1
previously approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test lgtm.
branch-0.2 is closing, please resolve the merge conflicts today if this needs to be in 0.2, or retarget to branch-0.3. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
exchange-reuse
branch
from
September 15, 2020 15:17
9e9f1a7
to
3526677
Compare
build |
@nartal1 I had to rebase against branch-0.3, dismissing your previous approval. |
nartal1
approved these changes
Sep 15, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Unit test for exchange re-use with AQE Signed-off-by: Andy Grove <andygrove@nvidia.com> * test that re-used exchanges are on GPU Signed-off-by: Andy Grove <andygrove@nvidia.com> * Test for re-use of GPU exchange Signed-off-by: Andy Grove <andygrove@nvidia.com> * Skip test against Spark 3.0.0 Signed-off-by: Andy Grove <andygrove@nvidia.com> * rebase Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Unit test for exchange re-use with AQE Signed-off-by: Andy Grove <andygrove@nvidia.com> * test that re-used exchanges are on GPU Signed-off-by: Andy Grove <andygrove@nvidia.com> * Test for re-use of GPU exchange Signed-off-by: Andy Grove <andygrove@nvidia.com> * Skip test against Spark 3.0.0 Signed-off-by: Andy Grove <andygrove@nvidia.com> * rebase Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#674) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Implements a unit test to check that GPU exchanges are re-used correctly when AQE is enabled.