Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for GPU exchange re-use with AQE #674

Merged
merged 5 commits into from
Sep 15, 2020

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Sep 4, 2020

Signed-off-by: Andy Grove andygrove@nvidia.com

Implements a unit test to check that GPU exchanges are re-used correctly when AQE is enabled.

@andygrove andygrove added the test Only impacts tests label Sep 4, 2020
@andygrove andygrove added this to the Aug 31 - Sep 11 milestone Sep 4, 2020
@andygrove andygrove self-assigned this Sep 4, 2020
@andygrove andygrove changed the title [WIP] Unit test for exchange re-use with AQE Unit test for exchange re-use with AQE Sep 8, 2020
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove changed the title Unit test for exchange re-use with AQE Unit test for GPU exchange re-use with AQE Sep 8, 2020
@andygrove
Copy link
Contributor Author

build

nartal1
nartal1 previously approved these changes Sep 8, 2020
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test lgtm.

@jlowe
Copy link
Member

jlowe commented Sep 11, 2020

branch-0.2 is closing, please resolve the merge conflicts today if this needs to be in 0.2, or retarget to branch-0.3.

@andygrove andygrove changed the base branch from branch-0.2 to branch-0.3 September 11, 2020 16:14
@andygrove andygrove dismissed nartal1’s stale review September 11, 2020 16:14

The base branch was changed.

Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Copy link
Contributor Author

build

@andygrove
Copy link
Contributor Author

@nartal1 I had to rebase against branch-0.3, dismissing your previous approval.

@andygrove andygrove merged commit 25b77f7 into NVIDIA:branch-0.3 Sep 15, 2020
@andygrove andygrove deleted the exchange-reuse branch December 17, 2020 15:25
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Unit test for exchange re-use with AQE

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* test that re-used exchanges are on GPU

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Test for re-use of GPU exchange

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Skip test against Spark 3.0.0

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* rebase

Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Unit test for exchange re-use with AQE

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* test that re-used exchanges are on GPU

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Test for re-use of GPU exchange

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* Skip test against Spark 3.0.0

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* rebase

Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#674)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants