fixUpJoinConsistency rule now works when AQE is enabled #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
Merged
andygrove
changed the title
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
abellina
reviewed
Sep 7, 2020
| // since they already started to execute | ||
| // since they already started to execute, but we verify that they are both on CPU or | ||
| // both on GPU | ||
| if (queryStages.map(isGpuQueryStage).distinct.size == 2) { |
There was a problem hiding this comment.
so for my edification, we can't get in this situation unless there is a bug, or perhaps a change in behavior from AQE rules proper?
There was a problem hiding this comment.
I think we could only get here due to a bug when planning query stages.
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
|
@abellina I was able to greatly simplify the logic in this PR. Please take a look when you can. |
revans2
approved these changes
Sep 8, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* fixUpJoinConsistency rule now works with AQE Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add comma to error message Signed-off-by: Andy Grove <andygrove@nvidia.com> * Improved validation checks and error messages Signed-off-by: Andy Grove <andygrove@nvidia.com> * bug fix: walk tree once to find shuffle exchanges and query stages Signed-off-by: Andy Grove <andygrove@nvidia.com> * code simplification Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* fixUpJoinConsistency rule now works with AQE Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add comma to error message Signed-off-by: Andy Grove <andygrove@nvidia.com> * Improved validation checks and error messages Signed-off-by: Andy Grove <andygrove@nvidia.com> * bug fix: walk tree once to find shuffle exchanges and query stages Signed-off-by: Andy Grove <andygrove@nvidia.com> * code simplification Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* first pass at a benchmark. Float only for now. * signoff Signed-off-by: Mike Wilson <knobby@burntsheep.com> Signed-off-by: Mike Wilson <knobby@burntsheep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GpuOverridesapplies afixUpJoinConsistencyrule to ensure that the inputs to aSortMergeJoinorShuffledHashJoinare either both on CPU, or both on GPU. We can't support a mix of CPU and GPU because the hashing algorithms are not compatible, and therefore the join would produce incorrect results.This PR adds a unit test for this rule, and also ensures that the rule is applied when AQE is enabled.
This closes #631