-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change shims dependency to spark-3.0.1 #689
Conversation
build |
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1 Signed-off-by: Tim Liu <timl@nvidia.com>
ed0be82
to
eb67d16
Compare
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, we may need to update some of the docs but I'll take a pass through after this. It looks like integration tests should just work as far as downloading right jar but I'll kick the build after merging to verify.
@@ -171,7 +171,7 @@ | |||
<!-- | |||
If you update a dependendy version so it is no longer a SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed this comment here right next to the version change. If we want the shim for 3.0.1 to be released you need to change the snapshot-shims profile too. @tgravescs do you want handle this with your docs update, or should I handle it separately?
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1 Signed-off-by: Tim Liu <timl@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com> Co-authored-by: NvTimLiu <50287591+NvTimLiu@users.noreply.github.com> Co-authored-by: Tim Liu <timl@nvidia.com>
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1 Signed-off-by: Tim Liu <timl@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com>
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1 Signed-off-by: Tim Liu <timl@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com> Co-authored-by: NvTimLiu <50287591+NvTimLiu@users.noreply.github.com> Co-authored-by: Tim Liu <timl@nvidia.com>
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1 Signed-off-by: Tim Liu <timl@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com>
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1 Signed-off-by: Tim Liu <timl@nvidia.com> Co-authored-by: Tim Liu <timl@nvidia.com> Co-authored-by: NvTimLiu <50287591+NvTimLiu@users.noreply.github.com> Co-authored-by: Tim Liu <timl@nvidia.com>
…IDIA#689) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
The original spark-rapids shims layer is against spark-3.0.1-SNAPSHOT.
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1
This change doesn't add/change unit tests.
No issue related to this change.