Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shims dependency to spark-3.0.1 #689

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Sep 9, 2020

The original spark-rapids shims layer is against spark-3.0.1-SNAPSHOT.
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

This change doesn't add/change unit tests.

No issue related to this change.

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Sep 9, 2020

build

As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Sep 9, 2020

build

Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, we may need to update some of the docs but I'll take a pass through after this. It looks like integration tests should just work as far as downloading right jar but I'll kick the build after merging to verify.

@tgravescs tgravescs merged commit 2ee1a8d into NVIDIA:branch-0.2 Sep 9, 2020
@jlowe jlowe added the build Related to CI / CD or cleanly building label Sep 9, 2020
@@ -171,7 +171,7 @@
<!--
If you update a dependendy version so it is no longer a SNAPSHOT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed this comment here right next to the version change. If we want the shim for 3.0.1 to be released you need to change the snapshot-shims profile too. @tgravescs do you want handle this with your docs update, or should I handle it separately?

revans2 pushed a commit that referenced this pull request Sep 9, 2020
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

Signed-off-by: Tim Liu <timl@nvidia.com>

Co-authored-by: Tim Liu <timl@nvidia.com>

Co-authored-by: NvTimLiu <50287591+NvTimLiu@users.noreply.github.com>
Co-authored-by: Tim Liu <timl@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

Signed-off-by: Tim Liu <timl@nvidia.com>

Co-authored-by: Tim Liu <timl@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

Signed-off-by: Tim Liu <timl@nvidia.com>

Co-authored-by: Tim Liu <timl@nvidia.com>

Co-authored-by: NvTimLiu <50287591+NvTimLiu@users.noreply.github.com>
Co-authored-by: Tim Liu <timl@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

Signed-off-by: Tim Liu <timl@nvidia.com>

Co-authored-by: Tim Liu <timl@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
As spark version 3.0.1 has been released, change shims dependency from 3.0.1-SNAPSHOT to 3.0.1

Signed-off-by: Tim Liu <timl@nvidia.com>

Co-authored-by: Tim Liu <timl@nvidia.com>

Co-authored-by: NvTimLiu <50287591+NvTimLiu@users.noreply.github.com>
Co-authored-by: Tim Liu <timl@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#689)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants