-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more checks to databricks build scripts #721
Conversation
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. I wonder if the script should auto-detect the plugin and cudf jar names that exist in the destination location and simply adapt to use those to match what the init script expects rather than forcing it to fail.
Please hold off on merging this for a few a build failed with this and I need to see if my check is wrong in the ok case. Yeah I want to make more automation to this, this was quick and easy check to add for now. |
sorry, I had tested that it failed but didn't wait for build to finish on positive case when there weren't extra files. Fixed great than and tested it. |
build |
* Add some more checks to databricks build scripts Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove extra newline * use the right -gt for bash
* Add some more checks to databricks build scripts Signed-off-by: Thomas Graves <tgraves@nvidia.com> * remove extra newline * use the right -gt for bash
…IDIA#721) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Add some checks to aid in debugging and catch if someone changes the init scripts