Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more checks to databricks build scripts #721

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

tgravescs
Copy link
Collaborator

Add some checks to aid in debugging and catch if someone changes the init scripts

@tgravescs
Copy link
Collaborator Author

build

@jlowe jlowe added the build Related to CI / CD or cleanly building label Sep 10, 2020
jlowe
jlowe previously approved these changes Sep 10, 2020
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I wonder if the script should auto-detect the plugin and cudf jar names that exist in the destination location and simply adapt to use those to match what the init script expects rather than forcing it to fail.

@tgravescs
Copy link
Collaborator Author

Please hold off on merging this for a few a build failed with this and I need to see if my check is wrong in the ok case.

Yeah I want to make more automation to this, this was quick and easy check to add for now.

@tgravescs
Copy link
Collaborator Author

sorry, I had tested that it failed but didn't wait for build to finish on positive case when there weren't extra files. Fixed great than and tested it.

@tgravescs
Copy link
Collaborator Author

build

@tgravescs tgravescs added this to the Aug 31 - Sep 11 milestone Sep 10, 2020
@tgravescs tgravescs merged commit 9582bc8 into NVIDIA:branch-0.2 Sep 10, 2020
@tgravescs tgravescs deleted the dbci branch September 10, 2020 19:20
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Add some more checks to databricks build scripts

Signed-off-by: Thomas Graves <tgraves@nvidia.com>

* remove extra newline

* use the right -gt for bash
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Add some more checks to databricks build scripts

Signed-off-by: Thomas Graves <tgraves@nvidia.com>

* remove extra newline

* use the right -gt for bash
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#721)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants