Fix issue with parquet partitioned reads #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
revans2
commented
Sep 11, 2020
| .createPartitionValues(partitionValues, partitionSchema) | ||
| withResource(partitionScalars) { scalars => | ||
| ColumnarPartitionReaderWithPartitionValues.addPartitionValues(cb, scalars) | ||
| if (partitionSchema.nonEmpty) { |
There was a problem hiding this comment.
Technically this change is not needed I originally started it to only grab the semaphore when there were partition values, but then I thought better and decided to grab it in all cases. I left this because I thought it made the code more readable, even though it works without the change.
If others disagree I am happy to remove it.
jlowe
approved these changes
Sep 11, 2020
tgravescs
approved these changes
Sep 11, 2020
|
python udf window tests are failing here too now. Not sure how they passed for the original PR. Because this is a P1 I am going to merge this in as is, and then we can decide how to fix the test separately. |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.12 to branch-23.02 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #718
It also fixes a few other things I found while in the code.
It acquires the GPU Semaphore in cases where we are returning a batch, even if it is just row counts.
It updates the tests to use the new small file config. I noticed it when I checked if my new test would fail without the fix in place, and it failed all 4 cases instead of just half of them that I thought it should.