Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing spark shim test suites #7673

Merged

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Feb 3, 2023

  • missing shim suites from Psnapshots profile,
  • buildver in the package name is sufficient, use a uniform class name SparkShimsSuite for easier scripting
  • add package with buildver as a decorator in a common base trait at runtime

reproduced and verified with

printf '%s' $(mvn help:evaluate -Dexpression=included_buildvers -q -pl dist -Psnapshots -DforceStdout) ',340' \
   | tr -s ',' $'\n' \
   | xargs -t -n 1 bash -c 'mvn test -pl sql-plugin \
       -Dsuites=com.nvidia.spark.rapids.shims.spark$1.SparkShimsSuite \
       -Dbuildver=$1' '{}'

These ScalaTests are not added for Databricks due #1320

Contributes to #7487

Signed-off-by: Gera Shegalov gera@apache.org

- remove buildver from class name for easier scripting, it's already
  present in the package name

Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov self-assigned this Feb 3, 2023
@gerashegalov gerashegalov added the test Only impacts tests label Feb 3, 2023
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

@jlowe jlowe merged commit c2f0ab7 into NVIDIA:branch-23.04 Feb 6, 2023
@gerashegalov gerashegalov deleted the missingSparkShimTestSuites-v2 branch February 6, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants