Fix shims provider override config not being seen by executors #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added
bug
|
build |
…t loads early Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
approved these changes
Sep 18, 2020
|
build |
1 similar comment
|
build |
|
I'm going to take a chance and merge this and let the tests run when we merge to main branch |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…A#798) * Fix shims provider override config not being seen by executors Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Also update shim provider class override from shuffle manager since it loads early Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…A#798) * Fix shims provider override config not being seen by executors Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Also update shim provider class override from shuffle manager since it loads early Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.12 to branch-23.02 [skip ci] [bot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#765 has an issue where the configuration for the shim override is not being seen by the ShimLoader on the executors. Rather than loading a fresh
SparkConfdirectly inShimLoaderthis leverages the config being passed to the driver/executor plugins to set the shim provider override class on startup if one is specified in the configs.Manually tested on a standalone cluster and verified the shim provider override message appears both in the driver logs and the executor logs.