Use contiguous table when deserializing columnar batch #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
abellina
approved these changes
Sep 24, 2020
revans2
approved these changes
Sep 25, 2020
|
Just FYI: |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* Use contiguous table when deserializing a table Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove unused numFields parameter from GpuColumnarBatchSerializer Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Use contiguous table when deserializing a table Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove unused numFields parameter from GpuColumnarBatchSerializer Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Use contiguous table when deserializing a table Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove unused numFields parameter from GpuColumnarBatchSerializer Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#851) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #849.
This was straightforward to implement, as @revans2 detailed it so excellently in the feature request.
I verified with a profile on a query that the contig splits have been removed after a shuffle. This cut the wall-clock time on a test query in local mode from over 32 seconds to under 25.
This also removes the unused
numFieldsparameter fromGpuColumnarBatchSerializersince I stumbled across it while doing this PR. Happy to move that to a separate PR if desired.