Arbitrary function call in UDF #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjxiz1992
changed the title
wjxiz1992
changed the title
|
@seanprime7 Added initial test case for this feature. Current exception: Issue created: #855 |
|
It would be better to create an issue for this too. @wjxiz1992 |
seanprime7
reviewed
Oct 14, 2020
seanprime7
force-pushed
the
func-call-in-udf
branch
13 times, most recently
from
691e5b4
to
ca62ffe
Compare
|
@wjxiz1992 @nvnedelman do you guys see if there is any other method call pattern that needs to be added to the test suite? |
seanprime7
changed the title
Signed-off-by: Allen Xu <allxu@nvidia.com>
seanprime7
force-pushed
the
func-call-in-udf
branch
from
ca62ffe
to
0bcfc17
Compare
|
Resolved merge conflicts. |
abellina
reviewed
Oct 26, 2020
There was a problem hiding this comment.
Just have a couple of nits @seanprime7. Looks good to me though.
With this change, method calls are inlined only if the method being
called
1. consists of operations supported by the UDF compiler, and
2. is one of the folllowing:
* a final method, or
* a method in a final class, or
* a method in a final class
Signed-off-by: Sean Lee <selee@nvidia.com>
seanprime7
force-pushed
the
func-call-in-udf
branch
from
0bcfc17
to
b37dba8
Compare
|
build |
abellina
approved these changes
Oct 27, 2020
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
* Add test case for arbitrary function call in UDF
Signed-off-by: Allen Xu <allxu@nvidia.com>
* Inline method calls when possible.
With this change, method calls are inlined only if the method being
called
1. consists of operations supported by the UDF compiler, and
2. is one of the folllowing:
* a final method, or
* a method in a final class, or
* a method in a final class
Signed-off-by: Sean Lee <selee@nvidia.com>
Co-authored-by: Allen Xu <allxu@nvidia.com>
Co-authored-by: Sean Lee <selee@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add test case for arbitrary function call in UDF
Signed-off-by: Allen Xu <allxu@nvidia.com>
* Inline method calls when possible.
With this change, method calls are inlined only if the method being
called
1. consists of operations supported by the UDF compiler, and
2. is one of the folllowing:
* a final method, or
* a method in a final class, or
* a method in a final class
Signed-off-by: Sean Lee <selee@nvidia.com>
Co-authored-by: Allen Xu <allxu@nvidia.com>
Co-authored-by: Sean Lee <selee@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add test case for arbitrary function call in UDF
Signed-off-by: Allen Xu <allxu@nvidia.com>
* Inline method calls when possible.
With this change, method calls are inlined only if the method being
called
1. consists of operations supported by the UDF compiler, and
2. is one of the folllowing:
* a final method, or
* a method in a final class, or
* a method in a final class
Signed-off-by: Sean Lee <selee@nvidia.com>
Co-authored-by: Allen Xu <allxu@nvidia.com>
Co-authored-by: Sean Lee <selee@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#854) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable arbitrary function call in UDF
Signed-off-by: Allen Xu allxu@nvidia.com