Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the 340 shim test #8688

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

firestarman
Copy link
Collaborator

@firestarman firestarman commented Jul 11, 2023

fixes #7676

Verified the test locally and it can pass now, so it is ok to enable the 340 shim test.

$ mvn test -pl sql-plugin   -Dsuites=com.nvidia.spark.rapids.shims.spark340.SparkShimsSuite   -Dbuildver=340
...
[INFO] 
[INFO] --- scalatest-maven-plugin:2.0.2:test (test) @ rapids-4-spark-sql_2.12 ---
Run starting. Expected test count is: 2
com.nvidia.spark.rapids.shims.spark340.SparkShimsSuite:
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
- spark shims version
- shuffle manager class
Run completed in 219 milliseconds.
Total number of tests run: 2
Suites: completed 1, aborted 0
Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  13.321 s
[INFO] Finished at: 2023-07-11T09:13:34Z
[INFO] ------------------------------------------------------------------------

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman
Copy link
Collaborator Author

build

@firestarman firestarman merged commit c40abc9 into NVIDIA:branch-23.08 Jul 12, 2023
25 checks passed
@sameerz sameerz added the test Only impacts tests label Jul 19, 2023
@firestarman firestarman deleted the fix-7676 branch November 9, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SparkShimsImpl class initialization in SparkShimsSuite for 340 too eager
3 participants