Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that receive-side batches use GpuColumnVectorFromBuffer to avoid #872

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

abellina
Copy link
Collaborator

Closes #860

This makes sure that received shuffle buffers in UCX are treated as contiguous tables, avoiding unnecessary calls to contig split in GpuCoalesceBatches

extra calls to contig_split

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
@abellina abellina added shuffle things that impact the shuffle plugin performance A performance related task/issue labels Sep 28, 2020
@jlowe jlowe added this to the Sep 28 - Oct 9 milestone Sep 28, 2020
@jlowe
Copy link
Member

jlowe commented Sep 28, 2020

build

@abellina abellina merged commit d2006ff into NVIDIA:branch-0.3 Sep 29, 2020
@abellina abellina deleted the fix_extra_contig_splits branch September 29, 2020 03:02
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
…id (NVIDIA#872)

extra calls to contig_split

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…id (NVIDIA#872)

extra calls to contig_split

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…id (NVIDIA#872)

extra calls to contig_split

Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#872)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue shuffle things that impact the shuffle plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] we need to mark columns from received shuffle buffers as GpuColumnVectorFromBuffer
2 participants