-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the non-consistency for spark.rapids.sql.format.parquet.multiThreadedRead
in RapidsConf.scala
#875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com>
fix: #874 |
Can one of the admins verify this patch? |
…rocessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com>
build |
tgravescs
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix @JustPlay
revans2
approved these changes
Sep 29, 2020
why CI error? |
it was from a build timeout, probably due to busy nodes |
build |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
…eadedRead` in RapidsConf.scala (NVIDIA#875) * fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com> * fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…eadedRead` in RapidsConf.scala (NVIDIA#875) * fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com> * fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…eadedRead` in RapidsConf.scala (NVIDIA#875) * fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com> * fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel} in configs.md Signed-off-by: houyu <houyu02@baidu.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#875) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
spark.rapids.sql.format.parquet.multiThreadedRead.enabled
it is saidWhen set to true, reads multiple small files within a partition more efficiently by reading each file in a separate thread in parallel on the CPU side before sending to the GPU. Limited by spark.rapids.sql.format.parquet.multiThreadedRead.numThreads and
spark.rapids.sql.format.parquet.multiThreadedRead.maxNumFileProcessed
but it shoud be
spark.rapids.sql.format.parquet.multiThreadedRead.maxNumFilesParallel