Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the non-consistency for spark.rapids.sql.format.parquet.multiThreadedRead in RapidsConf.scala #875

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

JustPlay
Copy link

@JustPlay JustPlay commented Sep 29, 2020

for spark.rapids.sql.format.parquet.multiThreadedRead.enabled it is said

When set to true, reads multiple small files within a partition more efficiently by reading each file in a separate thread in parallel on the CPU side before sending to the GPU. Limited by spark.rapids.sql.format.parquet.multiThreadedRead.numThreads and spark.rapids.sql.format.parquet.multiThreadedRead.maxNumFileProcessed

but it shoud be spark.rapids.sql.format.parquet.multiThreadedRead.maxNumFilesParallel

…rocessed,maxNumFilesParallel}

in configs.md

Signed-off-by: houyu <houyu02@baidu.com>
@JustPlay
Copy link
Author

fix: #874

@svcngcc
Copy link
Contributor

svcngcc commented Sep 29, 2020

Can one of the admins verify this patch?

…rocessed,maxNumFilesParallel}

in configs.md

Signed-off-by: houyu <houyu02@baidu.com>
@tgravescs
Copy link
Collaborator

build

Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @JustPlay

@tgravescs tgravescs added the documentation Improvements or additions to documentation label Sep 29, 2020
@tgravescs tgravescs added this to the Sep 28 - Oct 9 milestone Sep 29, 2020
@JustPlay
Copy link
Author

why CI error?

@tgravescs
Copy link
Collaborator

it was from a build timeout, probably due to busy nodes

@tgravescs
Copy link
Collaborator

build

@tgravescs tgravescs merged commit 66cb1a7 into NVIDIA:branch-0.3 Sep 29, 2020
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
…eadedRead` in RapidsConf.scala (NVIDIA#875)

* fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel}
in configs.md

Signed-off-by: houyu <houyu02@baidu.com>

* fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel}
in configs.md

Signed-off-by: houyu <houyu02@baidu.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…eadedRead` in RapidsConf.scala (NVIDIA#875)

* fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel}
in configs.md

Signed-off-by: houyu <houyu02@baidu.com>

* fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel}
in configs.md

Signed-off-by: houyu <houyu02@baidu.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…eadedRead` in RapidsConf.scala (NVIDIA#875)

* fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel}
in configs.md

Signed-off-by: houyu <houyu02@baidu.com>

* fixing spark.rapids.sql.format.parquet.multiThreadedRead.{maxNumFileProcessed,maxNumFilesParallel}
in configs.md

Signed-off-by: houyu <houyu02@baidu.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#875)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants