Update SpillableColumnarBatch to remove buffer from catalog on close #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
abellina
previously approved these changes
Sep 29, 2020
👎 Promotion blocked, new vulnerability foundVulnerability report
|
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
abellina
approved these changes
Sep 29, 2020
revans2
approved these changes
Sep 29, 2020
|
build |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
|
build |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
…VIDIA#879) * Update SpillableColumnarBatch to remove buffer from catalog on close Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add unit test Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove unused imports Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…VIDIA#879) * Update SpillableColumnarBatch to remove buffer from catalog on close Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add unit test Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove unused imports Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…VIDIA#879) * Update SpillableColumnarBatch to remove buffer from catalog on close Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Add unit test Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove unused imports Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#879) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com> Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpillableColumnarBatchneeds to close the buffer through the catalog rather than directly freeing the buffer. Otherwise we can leak buffer IDs being tracked by the catalog with no valid buffer underneath them.This also updates
TempSpillBufferIdto be a case class so Scala generates the hash/eq code for it, as this is often used in hash tables.