Save Databricks init scripts in the workspace [databricks] #8961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To close: NVIDIA#8916 Init scripts in DBFS will be deprecated sept 1 2023. Move Databricks init scripts in the workspace Signed-off-by: Tim Liu <timl@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
|
build |
Signed-off-by: Tim Liu <timl@nvidia.com>
|
build |
tgravescs
reviewed
Aug 9, 2023
|
Oh, I'd like to move DB workspace create and clean up into the common functions, let me try it. |
| @@ -129,7 +129,7 @@ String getDbType() { | |||
| void databricksBuild() { | |||
| def CLUSTER_ID = '' | |||
| def SPARK_MAJOR = BASE_SPARK_VERSION_TO_INSTALL_DATABRICKS_JARS.replace('.', '') | |||
| def dbfs_path = "$INIT_SCRIPTS_DIR-$DB_TYPE" | |||
| def ws_path = "$INIT_SCRIPTS_DIR-$DB_TYPE" | |||
There was a problem hiding this comment.
another way of doing this is to add spark-rapids github repo under /Repos. Then we can reference an initscript path /Repos/user@email/spark-rapids/...
There was a problem hiding this comment.
If we create a mirror spark-rapids GitHub repo on Databricks /Repos/user@email/spark-rapids dir, it is inflexible to point the init_script files at the PR for the pre-merge pipeline, or pointing to someone's private GitHub repo for testing pipelines?
Signed-off-by: Tim Liu <timl@nvidia.com>
sameerz
added
build
… common functions Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
force-pushed
the
db-init-scripts
branch
from
089bee3
to
648d04d
Compare
|
build |
NvTimLiu
requested review from
jlowe,
revans2,
GaryShen2008 and
zhanga5
as code owners
pxLi
approved these changes
Aug 24, 2023
jlowe
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close: #8916
Init scripts in DBFS will be deprecated sept 1 2023.
Move Databricks init scripts in the workspace
Signed-off-by: Tim Liu timl@nvidia.com